fix(vm): preserve guest TLS hostname#1416
Open
drew wants to merge 1 commit into
Open
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
TaylorMutch
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix VM sandbox provisioning for package-managed local mTLS gateways by adding the missing
/image-cachemountpoint and keeping guest callbacks on the certificate-validhost.openshell.internalalias.Related Issue
None
Changes
/image-cachewhen preparing sandbox VM rootfs images.host.openshell.internalas the VM host-loopback alias for loopback gateway endpoints.Testing
mise run pre-commit(failed only on existing ignored markdown plan docs:architecture/plans/issue-981-sandboxprofile-feedback.md,architecture/plans/issue-994-gateway-ingress-response.md; Rust tests in the run passed)env RUSTC_WRAPPER= cargo test -p openshell-driver-vmgit diff --check/opt/homebrew/bin/openshell sandbox create --no-keep --no-tty -- trueChecklist